This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs(prettier): add prettier support #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
docs/prettier
branch
2 times, most recently
from
bda87c6
to
61ebfd8
Compare
Generated by 🚫 dangerJS |
levithomason
force-pushed
the
docs/prettier
branch
from
61ebfd8
to
4052e02
Compare
This was referenced Mar 11, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds prettier support to the docs. All JSX and HTML is formatted.
Removed
beautify-js, replaced withprettierFixed all
<CodeSnippet />and<ExampleSnippet />errors and added auto formatting. This also now auto prints the JSX usingreact-element-to-jsx-string, so there is no need to define bothvalueas a multi-line string and provide arenderprop to render content. Just render the content and the string will be computed.Improved doc example layout and rendering of HTML:
Each doc example has a ✓ Prettier button in the upper right
Removed "close on click outside" for doc examples. This always gets in the way. I also reduced a lot of complexity in the
<Editor />component and<ComponentExample />in doing this.Removed 160 lines from the repo in the process :D