This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: Remove engines entry #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yarn.lock integrity" This reverts commit a950fcf.
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
miroslavstastny
approved these changes
Nov 27, 2018
kuzhelov
approved these changes
Nov 27, 2018
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 42 42
Lines 1455 1455
Branches 187 187
=======================================
Hits 1283 1283
Misses 167 167
Partials 5 5Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "chore: add engine entry for enforcing yarn > 1.10 to preserve… yarn.lock integrity"
This reverts commit a950fcf since this was not the proper fix. From @levithomason :
The engines field is not used to enforce development yarn versions. It is used to force your consumers to run your node package on a compatible version of node and NPM. See the engines docs here: https://docs.npmjs.com/files/package.json#engines.