This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(lodash): add types and fix errors #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
levithomason
reviewed
Nov 7, 2018
levithomason
reviewed
Nov 7, 2018
levithomason
reviewed
Nov 7, 2018
levithomason
reviewed
Nov 7, 2018
levithomason
reviewed
Nov 7, 2018
levithomason
reviewed
Nov 7, 2018
levithomason
reviewed
Nov 7, 2018
levithomason
added
needs author feedback
bmdalex
force-pushed
the
fix/lodash-types
branch
2 times, most recently
from
8e42568
to
aeb71d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 41 41
Lines 1432 1432
Branches 206 181 -25
=======================================
Hits 1267 1267
Misses 161 161
Partials 4 4
Continue to review full report at Codecov.
|
bmdalex
force-pushed
the
fix/lodash-types
branch
2 times, most recently
from
7da3788
to
beaadfc
Compare
bmdalex
added
🚀 ready for review
and removed
needs author feedback
bmdalex
force-pushed
the
fix/lodash-types
branch
2 times, most recently
from
5ccc733
to
3bf1f17
Compare
silviuaavram
reviewed
Nov 8, 2018
silviuaavram
approved these changes
Nov 8, 2018
kuzhelov
reviewed
Nov 9, 2018
docs/src/components/ComponentDoc/ComponentProp/ComponentPropFunctionSignature.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Nov 9, 2018
kuzhelov
reviewed
Nov 9, 2018
kuzhelov
reviewed
Nov 9, 2018
kuzhelov
reviewed
Nov 9, 2018
kuzhelov
reviewed
Nov 9, 2018
kuzhelov
reviewed
Nov 9, 2018
There was a problem hiding this comment.
have left several minor comments - overall looks very good to me 👍 Please, consider to review changes made for the sorting procedure for dataMock - have some doubts there.
One thing that really raises concerns is that we have to use key as .. for docs examples - while the goal is to avoid any TS artifacts from these snippets. At the same time, should emphasize that this is definitely not the problem of this PR, but rather is a broader issue.
Thanks!
bmdalex
force-pushed
the
fix/lodash-types
branch
from
3bf1f17
to
3e04a92
Compare
|
@levithomason @layershifter @kuzhelov |
kuzhelov
approved these changes
Nov 13, 2018
bmdalex
force-pushed
the
fix/lodash-types
branch
from
3e04a92
to
5fb3309
Compare
docs/src/components/ComponentDoc/ComponentProp/ComponentPropFunctionSignature.tsx
Outdated
Show resolved
Hide resolved
docs/src/components/ComponentDoc/ComponentProp/ComponentPropFunctionSignature.tsx
Outdated
Show resolved
Hide resolved
bmdalex
force-pushed
the
fix/lodash-types
branch
from
b1c8d40
to
4fdef94
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for adding
lodashtypes. Closes #420