feat(Input): expose Input's <input> element by inputRef

[silviuaavram]

Exposed the element through inputRef property of the Input component.

[codecov]

Codecov Report

Merging #377 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   91.71%   91.72%   +<.01%     
==========================================
  Files          41       41              
  Lines        1340     1341       +1     
  Branches      172      197      +25     
==========================================
+ Hits         1229     1230       +1     
  Misses        107      107              
  Partials        4        4

Impacted Files	Coverage Δ
src/components/Input/Input.tsx	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c96f8c0...88cdda1. Read the comment docs.

[bmdalex]

looks good to me

[levithomason]

Let's also keep the naming convention of this.ref for the root and this.*ref for other slots. This then would be this.inputRef.

[bmdalex]

looks like we're in some sort of contradiction here..

this used to be called this.inputRef and was changed to this.inputDomElement by me in #326 at @kuzhelov 's suggestion:

@kuzhelov @levithomason
can we get consensus and unblock @silviuavram ?

[silviuaavram]

I was following the way it was being handled in Portal.tsx . There, the actual HTMLElement is called triggerNode/portalNode. So at the very best, this may be renamed to this.inputNode . @Bugaa92 @kuzhelov what do you think?

[kuzhelov]

totally agree with @silviuavram's point - this variable definitely shouldn't be named as *Ref, as it is not a ref. Consider the difference that is introduced by ref semantics (taking React ref as an example):

const ref = ref
const element = ref ------ current -------> DOM element

vs

const element = DOM element

While ref, as implied by its name, provides additional level of indirection for accessing DOM element, the object that is stored in the inputDomElement variable is DOM element itself - thus, it definitely shouldn't be named as *ref - more than that, the name that is currently used is quite precise in terms of reflecting what the value of this variable stays for.