This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Popup): add 'target' prop #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
=========================================
- Coverage 89.75% 89.4% -0.35%
=========================================
Files 64 64
Lines 1259 1265 +6
Branches 182 163 -19
=========================================
+ Hits 1130 1131 +1
- Misses 126 131 +5
Partials 3 3
Continue to review full report at Codecov.
|
bmdalex
approved these changes
Oct 12, 2018
| @@ -34,6 +34,6 @@ export default class Ref extends Component<IRefProps> { | |||
| } | |||
|
|
|||
| render() { | |||
| return Children.only(this.props.children) | |||
| return this.props.children && Children.only(this.props.children) | |||
There was a problem hiding this comment.
otherwise, in case if children is not provided for the component, this will throw the error and fails rendering process for the whole tree - while, in contrast, if we will handle it this way, then for innerRef callback null will be validly provided as captured DOM element (as there are no elements rendered)
mnajdova
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
API changes
Target
Accepts DOM element that will be used as popup's target (instead of
triggerelement that is used by default). This prop will also allow to support 'bridge' scenarios, where it is necessary for client to display a popup for some DOM element that is not managed by React.This is an optional prop - if omitted (by default)
Popupwill still usetriggerelement as a target.