This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(Input): remove duplcated 'onChange' handling #310
Merged
kuzhelov
merged 3 commits into
master
from
fix/input-remove-duplicated-onchange-invocation
Oct 5, 2018
Merged
fix(Input): remove duplcated 'onChange' handling #310
kuzhelov
merged 3 commits into
master
from
fix/input-remove-duplicated-onchange-invocation
Oct 5, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
levithomason,
miroslavstastny and
mnajdova
as code owners
October 4, 2018 12:39
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
- Coverage 89.54% 89.54% -0.01%
==========================================
Files 62 62
Lines 1177 1176 -1
Branches 175 152 -23
==========================================
- Hits 1054 1053 -1
Misses 121 121
Partials 2 2
Continue to review full report at Codecov.
|
bmdalex
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mnajdova
reviewed
Oct 4, 2018
const inputClasses = classes.input | ||
|
||
return ( | ||
<ElementType className={classes.root} {...restProps} onChange={onChange}> | ||
<ElementType className={classes.root} {...restProps}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
mnajdova
approved these changes
Oct 4, 2018
layershifter
deleted the
fix/input-remove-duplicated-onchange-invocation
branch
November 9, 2018 09:24
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for each change of the input value we have
onChange
handler logic being called twice. This is happening due to the same event handling function is provided both for<input>
DOM element, as well as for the wrapping component (default is <div>
):