This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
BREAKING: apply styles prop to the root element #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
changed the title
levithomason
force-pushed
the
feat/root-styles
branch
2 times, most recently
from
033e7d9
to
63a8721
Compare
levithomason
force-pushed
the
feat/root-styles
branch
from
63a8721
to
ff2b851
Compare
kuzhelov
reviewed
Sep 17, 2018
| root: props.styles, | ||
| }, | ||
| ) | ||
| const accessibility: Accessibility = getAccessibility(stateAndProps, actionHandlers) |
kuzhelov
reviewed
Sep 17, 2018
| expect(shorthandComponentProps.styles).toBeDefined() | ||
| expect(shorthandComponentProps.styles.root).toEqual({ foo: 'bar' }) | ||
| }) | ||
|
|
||
| test(`shorthand's variables may be passed as '${shorthandPropertyName}' prop of ${ |
There was a problem hiding this comment.
yes, in that case we should seriously think about this variables guy as well..
kuzhelov
approved these changes
Sep 17, 2018
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
The
stylesprop accepted a map of component slots to styles:After
The
stylesprop now styles the root element only. Use shorthand props to style component slots: