Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix: Teams zwj gender emoji in Chrome #215

Merged
merged 4 commits into from
Sep 12, 2018

Conversation

markpete
Copy link
Contributor

@markpete markpete commented Sep 11, 2018

Chrome incorrectly handles zwj (zero-width joiner) gender emoji's and renders them as two emoji instead of a single one.
For an example, please see this emoji in both Chrome and Edge within stardust.
🤦‍♂️

Adding fonts that correctly support ZWJ's for Mac and Windows fixes the issue

Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍

Clean up tips:

Semantic PR Title

PR is failing the title check. It needs to conform to semantic pull request titles. These are essentially the same as Angular commit message guidelines.

This PR might be title fix: Teams theme zwj gender emoji in Chrome

Changelog

Since this is a user facing change, the CHANGELOG.md in the root of the project needs an entry. Instructions are included at the top of the changelog.

@markpete markpete changed the title Adding font support to correctly handle zwj gender emoji in Chrome fix: Teams zwj gender emoji in Chrome Sep 12, 2018
@levithomason levithomason added the needs author changes Author needs to implement changes before merge label Sep 12, 2018
@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@21b6028). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #215   +/-   ##
=========================================
  Coverage          ?   91.15%           
=========================================
  Files             ?       59           
  Lines             ?     1018           
  Branches          ?      159           
=========================================
  Hits              ?      928           
  Misses            ?       86           
  Partials          ?        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b6028...26c549a. Read the comment docs.

@levithomason levithomason added 🚀 ready for review and removed needs author changes Author needs to implement changes before merge labels Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants