This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popper): remove reference to popper element after destroy #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurokapsiar
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
| if (popperRef.current.popper) { | ||
| // Popper keeps a reference to the DOM node, which needs to be cleaned up | ||
| // temporarily fix it here until fixed properly in popper | ||
| popperRef.current.popper = null |
There was a problem hiding this comment.
I don't understand this. Setting the whole popperRef.current to null on the next line should be enough.
miroslavstastny
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popper keeps a reference to the DOM node, which needs to be cleaned up
Temporarily fix it in the popper wrapper component until fixed properly in popper.