Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

docs(Dialog): remove cancel button in an example containing X #1949

Merged
merged 4 commits into from
Sep 19, 2019

Conversation

lucivpav
Copy link
Contributor

@lucivpav lucivpav commented Sep 18, 2019

Both X and cancel button cannot coexist per design guidelines.

Don't forget to close the related VSTS issue once this is merged.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stardust is not a guideline to MS Teams.
I want to avoid merging this as it's very frequent thing in Web.

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #1949 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1949   +/-   ##
======================================
  Coverage    70.4%   70.4%           
======================================
  Files         892     892           
  Lines        7870    7870           
  Branches     2298    2274   -24     
======================================
  Hits         5541    5541           
  Misses       2316    2316           
  Partials       13      13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6c508...9d8e627. Read the comment docs.

@lucivpav lucivpav merged commit c5816bd into master Sep 19, 2019
@lucivpav lucivpav deleted the docs/dialog-x branch September 19, 2019 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants