This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs(Examples): use proper component variables #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
…cs/component-variables # Conflicts: # packages/react/src/lib/renderComponent.tsx
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1748 +/- ##
==========================================
+ Coverage 69.98% 69.99% +0.01%
==========================================
Files 868 868
Lines 7336 7322 -14
Branches 2142 2140 -2
==========================================
- Hits 5134 5125 -9
+ Misses 2196 2191 -5
Partials 6 6
Continue to review full report at Codecov.
|
Closed
miroslavstastny
approved these changes
Aug 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀
This PR improves
Try itsection in our docs examples to show only variables that were used in this example. It also handles updates properly.How?
I applied a monkey-patch to Fela renderer to catch updates in
renderRule(). It allows to get all values properly.