This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusTrapZone): firstFocusableSelector is fragile #1732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1566
Breaking change
Before:
firstFocusableSelector
was used only to specify the class name string selector..
was appended to the passed value.After:
firstFocusableSelector
can be any string selector as is used in API fordocument.querySelector
This PR introduces changes to
FocusTrapZone
andAutoFocusZone
to not limit a user to using class selectors only.Now it's a user responsibility to pass the whole string selector whether it's a
.blah
or#blah
or tagblah
etc. If this element won't be found in the container, the first tabbable element will be selected