This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(docs): add FAQ entry for Flex, Grid, Layout, Box, Segment #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
Example(s) should be given on Segment component. |
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
=======================================
Coverage 71.16% 71.16%
=======================================
Files 857 857
Lines 7102 7102
Branches 2032 2052 +20
=======================================
Hits 5054 5054
Misses 2042 2042
Partials 6 6Continue to review full report at Codecov.
|
Relevant issue #1530 |
bmdalex
reviewed
Jul 16, 2019
kuzhelov
reviewed
Jul 19, 2019
kuzhelov
reviewed
Jul 19, 2019
kuzhelov
reviewed
Jul 19, 2019
kuzhelov
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
looks good to me 👍
@mnajdova, @layershifter, please, share your thoughts on this. Thank you!
|
Please add the question in the title
|
mnajdova
reviewed
Jul 19, 2019
Fixed. |
delete-merged-branch
bot
deleted the
docs/box-segment-flex-grid-layout-faq
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clarify the differences between usages of the following components:
Flex,Grid,Layout,Box,Segment.This PR resolves Issue #1531.