Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Dropdown, DropdownItem, ListItem): Updating theme files #1523

Merged
merged 26 commits into from
Jun 28, 2019

Conversation

bcalvery
Copy link
Contributor

@bcalvery bcalvery commented Jun 20, 2019

Redline match for Dropdown and DropdownItem.

before:
image
image

after:
image
image
image

image
image
image

The redlines call for a "selected indictor" (checkmark) next to any item that is currently selected in the dropdown, and that is not implemented here because this is supposed to just be a style update.
image

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #1523 into master will decrease coverage by 0.11%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   71.66%   71.55%   -0.12%     
==========================================
  Files         838      838              
  Lines        6850     6858       +8     
  Branches     1961     1947      -14     
==========================================
- Hits         4909     4907       -2     
- Misses       1935     1945      +10     
  Partials        6        6
Impacted Files Coverage Δ
...ackages/react/src/components/Dropdown/Dropdown.tsx 88.52% <ø> (-0.03%) ⬇️
...-contrast/components/Dropdown/dropdownVariables.ts 0% <ø> (-50%) ⬇️
...themes/teams/components/Dropdown/dropdownStyles.ts 13.88% <ø> (ø) ⬆️
...eams-dark/components/Dropdown/dropdownVariables.ts 0% <ø> (ø) ⬆️
...src/themes/teams/components/List/listItemStyles.ts 20.83% <0%> (-2.98%) ⬇️
...es/teams/components/Dropdown/dropdownItemStyles.ts 8.33% <0%> (-11.67%) ⬇️
...mes/teams/components/Dropdown/dropdownVariables.ts 50% <100%> (ø) ⬆️
packages/react/src/components/List/ListItem.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4c68a...9b30208. Read the comment docs.

@bcalvery bcalvery removed the 🚧 WIP label Jun 20, 2019
@bcalvery bcalvery changed the title fix(Dropdown): Updating theme files fix(Dropdown, DropdownItem): Updating theme files Jun 20, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bcalvery bcalvery changed the title fix(Dropdown, DropdownItem): Updating theme files fix(Dropdown, DropdownItem, ListItem): Updating theme files Jun 26, 2019
Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the redline is correct here, let's merge 👍

@bcalvery bcalvery merged commit 774b5db into master Jun 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/dropdown-themeing branch June 28, 2019 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants