Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(types): for theme #1508

Merged
merged 4 commits into from
Jun 18, 2019
Merged

fix(types): for theme #1508

merged 4 commits into from
Jun 18, 2019

Conversation

kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Jun 17, 2019

TODO

  • update changelog

This PR introduces the following fixes:

  • lots of duplicated information removed: originally all component names were duplicated for input/output styles/variables types
  • prop types for styles/variables were restricted (provided as generic parameters)
  • missing components were added to theme's type definitions
    • AccordionTitle
    • AccordionContent
    • Checkbox
    • Flex (and related)
    • Loader
    • Toolbar (and related)
    • Tooltip (and related)

@kuzhelov kuzhelov changed the title fix(types): theme fix(types): for theme Jun 17, 2019
@kuzhelov kuzhelov added 🧰 fix Introduces fix for broken behavior. 🚀 ready for review labels Jun 17, 2019
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #1508 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1508   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files         825      825           
  Lines        6207     6207           
  Branches     1796     1796           
=======================================
  Hits         4547     4547           
  Misses       1655     1655           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e0d50...3a5ee23. Read the comment docs.

@kuzhelov kuzhelov merged commit 173f995 into master Jun 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/types-for-theme branch June 18, 2019 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants