This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): click/keypress handling logic for content #1482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1324
TODO
Problem
Click on popup content's button toggles popup content to close.
Cause
The cause of the problem is rather convoluted. The reason popup closes is because it 'sees' click on the content's button as outside click.
Why?
Popup
has the following logic to detect outside clicksWhile idea is straightforward, it turns out that currently we have problems caused by order of click events processing. When button inside of popup content is clicked,
Resolution
To address it, for now,
capture
prop of popup's<EventListener />
is used - this activatescapture
subscription mode for DOM events, which guarantees that corresponding event handler will be invoked before any other event's effects. (https://developer.mozilla.org/ru/docs/Web/API/EventTarget/addEventListener)Additional notes
These changes will be merged after #1463 , where e2e (browser) test is introduced for the issue's case.