This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
refactor/accessibility-types
branch
from
May 29, 2019 14:12
eea3065
to
ed10dc0
Compare
layershifter
changed the title
Refactor/accessibility types
chore(accessibility): refactor types
May 29, 2019
layershifter
force-pushed
the
refactor/accessibility-types
branch
from
May 29, 2019 14:23
ed10dc0
to
eddb9cc
Compare
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
May 29, 2019 14:23
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
- Coverage 73.27% 73.26% -0.02%
==========================================
Files 802 802
Lines 6025 6021 -4
Branches 1775 1774 -1
==========================================
- Hits 4415 4411 -4
Misses 1604 1604
Partials 6 6
Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Jun 3, 2019
sophieH29
approved these changes
Jun 3, 2019
jurokapsiar
approved these changes
Jun 3, 2019
…/github.com/stardust-ui/react into refactor/accessibility-types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should decouple types related to React implementation and keep framework agnostic stuff separately.
Breaking Changes
These types are exported publicly, so I consider these changes as breaking. All related to types naming which allows us to have more meaningful names.
AccessibilityBehavior
=>ReactAccessibilityBehavior
KeyboardHandler
=>KeyboardEventHandler
ActionsKeyHandler
=>AccessibilityKeyHandlers
OnKeyDownHandler
=>AccessibilityHandlerProps
keyboardHandlerFilter
Was renamed to
shouldHandleOnKeys
and refactored to be pure function. No user facing changes.Types improments
Accessibility
type is now generic and allows to define props strictlyactionsHandlers
now useReact.KeyboardEvent
instead ofKeyboardEvent
, how it should be