-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
=======================================
Coverage 72.32% 72.32%
=======================================
Files 759 759
Lines 5692 5692
Branches 1687 1663 -24
=======================================
Hits 4117 4117
Misses 1569 1569
Partials 6 6
Continue to review full report at Codecov.
|
@@ -49,9 +50,12 @@ class FlexItem extends UIComponent<ReactProps<FlexItemProps>> { | |||
|
|||
static propTypes = { | |||
...commonPropTypes.createCommon({ | |||
children: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: children
argument in createCommon can be boolean or string. Would it make sense to pass direct value (like you do on line 57) as well (or instead of the string)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an interesting question. I can add as a separate PR options for passing direct value for the children and content options.
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
=======================================
Coverage 72.33% 72.33%
=======================================
Files 759 759
Lines 5694 5694
Branches 1664 1688 +24
=======================================
Hits 4119 4119
Misses 1569 1569
Partials 6 6
Continue to review full report at Codecov.
|
FIxing this console warning: