-
Notifications
You must be signed in to change notification settings - Fork 55
feat(Input): move styles to Base theme #1247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1247 +/- ##
==========================================
- Coverage 71.58% 71.57% -0.02%
==========================================
Files 730 731 +1
Lines 5582 5583 +1
Branches 1612 1634 +22
==========================================
Hits 3996 3996
- Misses 1581 1582 +1
Partials 5 5
Continue to review full report at Codecov.
|
…ub.com/stardust-ui/react into chore/move-input-styles
|
||
inputPadding: `${pxToRem(7)} ${pxToRem(12)}`, | ||
inputFocusBorderBottomColor: siteVars.colors.primary[500], | ||
inputFocusBorderColor: `transparent transparent ${siteVars.colors.primary[500]} transparent`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate that we are using input
as part of the variables name, but the input
is a shorthand of the Input
component, so I don't see any better way... :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have better ideas there, too :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR moves
Input
styles to Base theme.BREAKING CHANGES
In
InputVariables
theinputFocusBorderBottomColor
variables was renamed toinputFocusBorderColor
. It allows to customize all borders instead of onlybottom
.Before
After