This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(docs): regexp for component examples selection #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
added
🧰 bug
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 88.35% 88.35%
=======================================
Files 47 47
Lines 773 773
Branches 109 100 -9
=======================================
Hits 683 683
Misses 87 87
Partials 3 3Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Aug 23, 2018
| @@ -33,7 +33,9 @@ export default class ComponentExamples extends React.Component<IComponentExample | |||
| const allPaths = exampleContext.keys() | |||
|
|
|||
| // rule #1 | |||
| const indexPath = _.find(allPaths, path => new RegExp(`${displayName}/index.tsx$`).test(path)) | |||
| const indexPath = _.find(allPaths, path => | |||
| new RegExp(`([/]|^)${displayName}[/]index[.]tsx$`).test(path), | |||
There was a problem hiding this comment.
I would vote for \. and similar to be cleaner than [.]
mnajdova
approved these changes
Aug 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was discovered when on the page of
Layoutcomponent examples forItemLayoutwere presented. This was caused by the fact that used regexp was too lose to filter out false positive matches.Previously
ItemLayoutexamples are presented onLayoutpage