-
Notifications
You must be signed in to change notification settings - Fork 55
fix(docs): Fix routing for accessibility documentation #1208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1208 +/- ##
=======================================
Coverage 82.55% 82.55%
=======================================
Files 751 751
Lines 8854 8854
Branches 1178 1178
=======================================
Hits 7309 7309
Misses 1530 1530
Partials 15 15 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changelog entry
</ul> | ||
</li> | ||
<li> | ||
{link('Keyboard Navigation', '/accessibility#keyboard-navigation')} | ||
{link('Keyboard Navigation', 'accessibility#keyboard-navigation')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that those are the links to the same page, suggest to use just id selector as their content - this would solve all the maintainability headache:
{link('Keyboard Navigation', '#keyboard-navigation')}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried that approach, unfortunately, it does not work that way. That query part is not added to the end but rewrites the path
They're broken across all pages. I think a separate PR should be addressed to fix that issue. Filed a bug #1210 |
When heading navigation within the article was implemented initially for Accessibility documentation, there were "/" sign added to each link. Since deployed version has a different route
/react/
, these links were rewriting/react/
part what caused 404 error when navigating.