Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix: (Icon) search & table icon update #1011

Merged
merged 3 commits into from
Mar 5, 2019

Conversation

jaanus03
Copy link
Contributor

@jaanus03 jaanus03 commented Mar 4, 2019

This PR updates search & table icons:

Old search icons
screenshot 2019-03-04 at 17 28 15

New search icons
screenshot 2019-03-04 at 17 22 10

Old table icons
screenshot 2019-03-04 at 17 26 53

New table icons
screenshot 2019-03-04 at 17 24 29

@jaanus03 jaanus03 force-pushed the jaanusp/search-table-icon-update branch from cd4c9a9 to 5af6058 Compare March 4, 2019 15:33
@jaanus03 jaanus03 changed the title Fix: Search & table icon update fix (Icon): search & table icon update Mar 4, 2019
@jaanus03 jaanus03 changed the title fix (Icon): search & table icon update fix: (Icon) search & table icon update Mar 4, 2019
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #1011 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
+ Coverage   81.37%   81.37%   +<.01%     
==========================================
  Files         673      673              
  Lines        8697     8699       +2     
  Branches     1475     1475              
==========================================
+ Hits         7077     7079       +2     
  Misses       1605     1605              
  Partials       15       15
Impacted Files Coverage Δ
...c/themes/teams/components/Icon/svg/icons/table.tsx 100% <ø> (ø) ⬆️
.../themes/teams/components/Icon/svg/icons/search.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a0087...6c7b18a. Read the comment docs.

Copy link
Collaborator

@codepretty codepretty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just remember to add a changelog entry

@jaanus03 jaanus03 force-pushed the jaanusp/search-table-icon-update branch from 5af6058 to 6c7b18a Compare March 5, 2019 11:11
@jaanus03 jaanus03 merged commit 19dfbe3 into master Mar 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the jaanusp/search-table-icon-update branch March 5, 2019 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants