Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P0] Making RepresentationConfig a PretrainedConfig object #157

Open
frankaging opened this issue May 10, 2024 · 0 comments
Open

[P0] Making RepresentationConfig a PretrainedConfig object #157

frankaging opened this issue May 10, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@frankaging
Copy link
Collaborator

Descriptions:

Currently, RepresentationConfig is defined as a namedtuple, https://github.com/stanfordnlp/pyvene/blob/main/pyvene/models/configuration_intervenable_model.py#L11C1-L13C28. This makes new arguments really hard to be added into the config, and cause a lot of saving and loading issues when the config gets larger. One good thing about this config is that all the fields are primitive types, and are serializable.

The solution is to turn RepresentationConfig into another HuggingFace PretrainedConfig object which is more extensible, and all the saving and loading are already handled by PretrainedConfig itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants