Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HFClientVLLM is missing http_request_kwargs #1249

Closed
MohammedAlhajji opened this issue Jul 5, 2024 · 2 comments
Closed

HFClientVLLM is missing http_request_kwargs #1249

MohammedAlhajji opened this issue Jul 5, 2024 · 2 comments

Comments

@MohammedAlhajji
Copy link
Contributor

I have model deployed via VLLM; however, I have to use a proxy at my work PC and I run into certificate issues often due to the proxy.

I've noticed that HFClientTGI has a useful extra argument http_request_kwargs. I'd love to add it to HFClientVLLM if there's no limitation to that
@MohammedAlhajji
Copy link
Contributor Author

I've made this branch to fix this issue #1250

@okhat
Copy link
Collaborator

okhat commented Jul 8, 2024

Thanks a lot for opening the PR!

@okhat okhat closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okhat @MohammedAlhajji