fix: allow eslint-plugin-promise v5 as peer dependency #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
Closed
|
Closing per #183 (comment) |
|
I prefer this PR @divlo since, as I've argued before, this is the minimal change for fixing the problem of eg. @erezrokah. #183 contains additional changes that are not needed for this very fix and which are possible to object to. |
theoludwig
approved these changes
May 24, 2021
voxpelli
approved these changes
May 24, 2021
|
🎉 Congrats on getting your first pull request landed! |
This happened to be at the top of my inbox so I looked at the small change and approved it 😅 Unfortunately I don't have time to read thru #183 right now, but my take in just quickly glancing at the changes (sorry if this has been discussed) is that it's always easier to merge smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
eslint-plugin-promisev5 as peer dependency.Fixes the following use case netlify/eslint-config-node#160 (comment) and extracted from #183 to separate concerns.