Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable indent in conflicting JSX indent touched code #178

Closed
wants to merge 1 commit into from

Conversation

bcomnes
Copy link
Member

@bcomnes bcomnes commented Oct 27, 2020

Fixes #177

My only worry is that there is some use for indent rules inside of JSX that are intended to overlap with standard-jsx? Not sure, anyone familiar?

Fixes #177

My only worry is that there is some use for indent rules inside of JSX that are intended to overlap with standard-jsx? Not sure, anyone familiar?
@bcomnes bcomnes requested a review from feross October 27, 2020 15:56
@bcomnes
Copy link
Member Author

bcomnes commented Oct 27, 2020

In terms of testing, this does fix the conflicting rule problem noted in the issue.

@feross
Copy link
Member

feross commented Oct 28, 2020

Thanks for the PR! I'll fix this by copying the full list of nodes that eslint-config-airbnb uses. Will do in another PR.

@feross feross closed this Oct 28, 2020
@feross feross deleted the indent-jsx-indent branch October 28, 2020 02:59
feross added a commit that referenced this pull request Oct 28, 2020
@bcomnes
Copy link
Member Author

bcomnes commented Oct 28, 2020

Sgtm

@feross
Copy link
Member

feross commented Oct 28, 2020

Fixed in 15.0.1.

@theclive
Copy link

theclive commented Nov 13, 2020

Hi Guys,

This PR has messed with our JSX formatting, and pretty much every file now has ESLint errors. When we format it the way ESLint wants it we end up with something very undesirable. Here's an example:

image

It doesn't really make sense for us to override the entire indent config attribute just to remove the new "ignoredNodes" addition!
What do you suggest we do to resolve this?

Regards,
Clive

P.S. We have no issues with our multiline ternary expressions in JSX post v15.

@feross
Copy link
Member

feross commented Nov 14, 2020

@theclive Can you share a copy-pastable code example that exhibits the undesirable behavior so we can try to reproduce it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

offsetTernaryExpressions and multiline-ternary conflicts with jsx/indent (standard-react)
3 participants