Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashi-vault-engine-name parameter #399

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

eiabea
Copy link
Contributor

@eiabea eiabea commented Aug 22, 2024

Fixes #395

@evgeny-stakewise
Copy link
Contributor

@eiabea don't forget to run linters. For details see the guide for contributors.

@evgeny-stakewise
Copy link
Contributor

@eiabea first commit is not signed (not verified). PR can not be merged. Pls setup GPG signature (if not yet) and recreate PR from another branch.

eiabea and others added 5 commits August 27, 2024 12:24
Signed-off-by: eiabea <developer@eiabea.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
@eiabea eiabea force-pushed the add-hashi-vault-engine-name branch from 1dc9c5f to 8dbe915 Compare August 27, 2024 10:25
@eiabea
Copy link
Contributor Author

eiabea commented Aug 27, 2024

@eiabea first commit is not signed (not verified). PR can not be merged. Pls setup GPG signature (if not yet) and recreate PR from another branch.

Thank you for the hint. I got a new machine and forgot to enable signing off by default

@evgeny-stakewise evgeny-stakewise merged commit 9b831ec into stakewise:master Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HashiCorp Vault secret engine name is hardcoded
3 participants