Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple --hashi-vault-key-path parameters #390

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Add support for multiple --hashi-vault-key-path parameters #390

merged 2 commits into from
Aug 19, 2024

Conversation

mksh
Copy link
Contributor

@mksh mksh commented Aug 8, 2024

  • Allow passing multiple --hashi-vault-key-path parameters
  • Fetch secrets from Hashicorp Vault in parallel, batched in chunks
  • Verify no duplicate secrets are fetched from Hashicorp Vault
  • Tests for new cases: parallel fetching of paths, sequential fetching of 2 chunks, duplicate secrets

kamsz
kamsz approved these changes Aug 9, 2024
View reviewed changes
Copy link

@kamsz kamsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

evgeny-stakewise
evgeny-stakewise reviewed Aug 13, 2024
View reviewed changes
src/config/settings.py Outdated Show resolved Hide resolved
src/remote_db/tests/test_commands.py Outdated Show resolved Hide resolved
src/commands/create_keys.py Outdated Show resolved Hide resolved
@mksh mksh force-pushed the hashi-vault-multiple-paths branch from 72b9ca9 to 9a424c8 Compare August 19, 2024 09:40
@evgeny-stakewise evgeny-stakewise merged commit 161b149 into stakewise:master Aug 19, 2024
@mksh mksh deleted the hashi-vault-multiple-paths branch August 22, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamsz kamsz kamsz approved these changes

@evgeny-stakewise evgeny-stakewise evgeny-stakewise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mksh @kamsz @evgeny-stakewise