Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Franklin types to api module #119

Open
jisantuc opened this issue Jun 29, 2020 · 1 comment
Open

Migrate Franklin types to api module #119

jisantuc opened this issue Jun 29, 2020 · 1 comment

Comments

@jisantuc
Copy link
Contributor

Improvement

We have a number of types in Franklin that would be useful for things outside of the Franklin monolith. For instance, the types of query parameters are maintained in Franklin, but are also maintained (and sometimes out of sync) in projects that would like to communicate with Franklin instances. We should instead move types upstream to an api-client (or similar) package that both Franklin and Franklin consumers can depend on. That should live either here or in Franklin. An argument could be made that it should live here because "Franklin" doesn't have the same obvious STAC branding that stac4s has. An argument could be made that it belongs in Franklin because that's where its default consumer lives.

@pomadchin
Copy link
Collaborator

pomadchin commented Jun 30, 2020

GeoTrellis server has also its own version of SearchFilters which is just a copy of what franklin has and it already caused troubles (incorrect temporal extent json representation for stac api queries, since static stac and stac api represent it in a different format): https://github.com/geotrellis/geotrellis-server/blob/develop/stac-example/src/main/scala/geotrellis/stac/api/SearchFilters.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants