Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure tool plugins to not run if no files of their desired type are available. #422

Closed
xydesa opened this issue Jun 7, 2022 · 0 comments
Closed

Restructure tool plugins to not run if no files of their desired type are available. #422

xydesa opened this issue Jun 7, 2022 · 0 comments
Assignees
@xydesa

Comments

@xydesa
Copy link
Collaborator

xydesa commented Jun 7, 2022

There's no reason to run a tool plugin if there are no files available of the type that they operate on. Restructure the tool plugins so they do this.
@xydesa xydesa self-assigned this Jun 7, 2022
@xydesa xydesa mentioned this issue Jun 8, 2022
Merged
gregtkogut pushed a commit that referenced this issue Jun 14, 2022
@xydesa
[#422] tool plugin refactor (#423)
dd0f6a4 
* First pass at refactoring the scan function in tool plugins.

* Adding another check to make sure file types exist.

* Fixing mypy issues, converting tool plugins to the new construction where possible. Updating unit tests where needed.

* Adding unit tests for new branches of catkin_lint tool plugin.

* Disabling assignment-from-no-return on overridden function.

* black formatting.

* black formatting again.

* fixing pytlint disable and black formatting.

* Forgot to convert one test in the catkin_lint tool plugin unit tests.
@xydesa xydesa closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xydesa xydesa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xydesa