Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property sort order recess / smacss/ concentric doesn't work #10

Closed
ghost opened this issue Apr 19, 2018 · 2 comments
Closed

Property sort order recess / smacss/ concentric doesn't work #10

ghost opened this issue Apr 19, 2018 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Apr 19, 2018

Problem Description

Property resolves alphabetically, but not in other orders like recess, smacss or concentric.

They're hints in the code, but it seems that the yaml files are missing.

Steps to recreate

  • Put sass-lint.yml at the root of the project with following content:
resolvers:
  property-sort-order:
    - 1
    - order: concentric
  • Run sass-lint-auto-fix -c sass-lint.yml
  • Property sort is alphabetically
@srowhani srowhani added the bug Something isn't working label Apr 19, 2018
@srowhani
Copy link
Owner

This appears to be an issue with documentation. As it is currently when resolving files, the context for the rules given to the rule resolver will come from sass-lint.

By default, sass-lint will look for a .sass-lint.yml or .sasslintrc in the root.
https://github.com/sasstools/sass-lint/blob/develop/lib/config.js#L54

So in your case, for your project you would add a .sass-lint.yml in the root of your project with:

rules:
  property-sort-order:
    - 1
    - order: concentric

The config file specified when running sass-lint-auto-fix is to enable or disable rule resolvers - if you only wish to apply certain types of fixes. Documentation regarding the topic, and include CLI flag to specify custom sass-lint config should be added.

@srowhani srowhani added good first issue Good for newcomers and removed bug Something isn't working labels Apr 20, 2018
@ghost
Copy link
Author

ghost commented Apr 21, 2018

Thank you for your feedback. Makes total sense and works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant