Remove OpenCL dependency #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove dependency on OpenCL (currently not used) - Update search path for rendering libs in plugin CMakeLists - Provide cgal::Point template specialisation for OceanTilePrivate::UpdateMesh needed when compiling for arm64 Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on OpenCL which is not currently used in the plugins. There is also an update to the search path for the rendering libs in the plugin CMakeLists.txt as part of the name migration. Finally there is a template specialisation of OceanTilePrivate::UpdateMesh for cgal::Point which is needed when compiling for arm64.
Notes
gz-simas there are breaking changes to library and directory names