Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI doesn't seem to run FE linter #236

Closed
benjreinhart opened this issue Aug 30, 2024 · 1 comment · Fixed by #238
Closed

CI doesn't seem to run FE linter #236

benjreinhart opened this issue Aug 30, 2024 · 1 comment · Fixed by #238

Comments

@benjreinhart
Copy link
Contributor

CI used to run eslint and catch things like missing dependencies in useEffect. I think it may have gotten dropped in #201

cc @versecafe
@versecafe
Copy link
Collaborator

versecafe commented Aug 31, 2024 •
edited
Loading

@benjreinhart is it okay if I go in and do a full eslint overhaul, starting with getting the base CI included again but moving to a rules package and strictening things?

@versecafe versecafe mentioned this issue Aug 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds eslint to CI and supports _ignore versecafe/srcbook
2 participants
@benjreinhart @versecafe