-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add explicit imports to QtSvg module #55
Conversation
I don't think so because they don't belong to the module itself. @Nodd? |
Ehh ?? |
I really don't see the need of it. That's normally how Python works, i.e. imported symbols remain in the namespace. |
Yes, I know how it works... this not about how python works or does not, but a user would be able to import PYQT4 from QtCore module and it should not, cause those symbols live in qtpy. not int qtpy.QtCore. We should not encourage that use |
I doubt anyone would confuse our constants with proper Qt objects, but I'm neutral about removing or leaving them. Besides, this needs a rebase now ;-) |
I think that deleting them is indeed cleaner. I don't hink that many users would import it from here, but for example |
ok , will do :-) |
a51049a
to
b748df4
Compare
@ccordoba12, see :-p, its the fastest by far |
This looks good to me :-) |
Use star imports in QtSvg again instead of direct ones (reverts PR #55)
@ccordoba12, @Nodd should we delete
PYQT4, PYQT5, PYSIDE, PythonQtError
from the module at the end?del PYQT4, PYQT5, PYSIDE, PythonQtError
?