PR: [PyQt6] Add exec_/print_, and add QOpenGLWidget/QShortcut to QtWidgets #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kumattau
force-pushed
the
pyqt6-exec_-print_
branch
from
1e3aef9
to
4d30014
Compare
|
I updated commit comments only |
kumattau
force-pushed
the
pyqt6-exec_-print_
branch
from
4d30014
to
cd77e14
Compare
dalthviz
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyQt6 document says
https://www.riverbankcomputing.com/static/Docs/PyQt6/pyqt5_differences.html
But I think it is better that QtPy supports exec_() and print_()
because the latest PySide2 5.15.2 supports exec_() only and PySide2/PySide6 support print_() only.
I think we can simply assign exec to exec_ : QApplication.exec_ = QApplication.exec (print_ is also the same)
I picked up exec_ and print_ in PySide6, and add them to corresponding classes of PyQt6.
Additionally, I added QOpenGLWidget and QShortcut to QtWidgets of PyQt6 same as PySide6.
Related to: #233 (comment)
Fixes #258