PR: Add support for PyQt 4.6 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eephillip originally reported this in git-cola/git-cola#692 |
ccordoba12
reviewed
May 4, 2017
qtpy/QtWidgets.py
Outdated
| del QMatrix3x4, QMatrix4x2, QMatrix4x3, QMatrix4x4 | ||
| del QQuaternion, QRadialGradient, QRawFont, QRegExpValidator | ||
| del QStaticText, QTouchEvent, QVector2D, QVector3D, QVector4D | ||
| del qFuzzyCompare |
There was a problem hiding this comment.
Please use a single del to remove all these symbols (as it's done below).
There was a problem hiding this comment.
Good catch, I'll repush this branch shortly with that fixup.
|
I'm +1 for this change. I just left a minor comment, then I'll merge. |
davvid
force-pushed
the
pyqt46
branch
2 times, most recently
from
7c09798
to
731d0bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyQt4 4.6 on Centos 6.8 reports itself as:
This version is missing symbols from QtGui that causes qtpy to
fail. Allow
import qtpyto work in this environment.Signed-off-by: David Aguilar davvid@gmail.com