Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is not necessary to fetch all user sessions if unlimited sessions are set in the ConcurrentSessionControlAuthenticationStrategy. #9152

Closed
avpoloz opened this issue Oct 26, 2020 · 0 comments · Fixed by #9153
Closed

It is not necessary to fetch all user sessions if unlimited sessions are set in the ConcurrentSessionControlAuthenticationStrategy. #9152

avpoloz opened this issue Oct 26, 2020 · 0 comments · Fixed by #9153
Assignees
@eleftherias
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
5.5.0-M1

Comments

@avpoloz
Copy link
Contributor

avpoloz commented Oct 26, 2020

Expected Behavior

In ConcurrentSessionControlAuthenticationStrategy.onAuthentication, If maximumSessions value settled to -1, which means there are no restrictions for user sessions count, then no need fetch all user sessions in that case. We should just skipping any following computations.

Current Behavior

ConcurrentSessionControlAuthenticationStrategy.onAuthentication start with getAllSessions whatever or not there is restriction on session count, and if is not, then just does nothing with retreived data.

Context

Save little peace of computing resources.
@avpoloz avpoloz added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Oct 26, 2020
@avpoloz avpoloz mentioned this issue Oct 26, 2020
Merged
@eleftherias eleftherias self-assigned this Oct 27, 2020
@eleftherias eleftherias added in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 27, 2020
@eleftherias eleftherias added this to the 5.5.0-M1 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M1
Development

Successfully merging a pull request may close this issue.

Change guard expressions order avpoloz/spring-security
2 participants
@eleftherias @avpoloz