Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Specifying Identifier for relying-party-registrations Element #14487

Closed
jzheaux opened this issue Jan 23, 2024 · 1 comment
Closed

Support Specifying Identifier for relying-party-registrations Element #14487

jzheaux opened this issue Jan 23, 2024 · 1 comment
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jan 23, 2024

When using <relying-party-registrations> to configure a RelyingPartyRegistrationRepository, it would be helpful to be able to give it an identifier so that it can be referred to other custom SAML components like so:

<relying-party-registrations id="ref">
    <relying-party-registration ..../>
    <asserting-party ... />
</relying-party-registrations>

<b:bean class="org.springframework.security.saml2.provider.service.web.authentication.OpenSaml4AuthenticationRequestResolver">
    <b:constructor-arg ref="ref"/>
    <b:property ref="relayStateResolver"/>
</b:bean>

...

This would involve updating RelyingPartyRegistrationsBeanDefinitionParser, its test file, and the accompanying .rnc file.

Related to gh-14417

@jzheaux jzheaux added type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with in: saml2 An issue in SAML2 modules labels Jan 23, 2024
@abhishek-bafna-amdhan
Copy link

Hello @jzheaux. I noticed another issue that can be looked along with this issue (#14645)

Both these issues may require changes in RelyingPartyRegistrationsBeanDefinitionParser. Please do have a look into the issue and provide your valuable feedback.

@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Apr 10, 2024
@jzheaux jzheaux self-assigned this Apr 10, 2024
@jzheaux jzheaux added this to the 6.3.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
Status: Done
Development

No branches or pull requests

2 participants