Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in ACLS document #12270

Closed
Wilson-Emmanuel opened this issue Nov 22, 2022 · 4 comments
Closed

Error in ACLS document #12270

Wilson-Emmanuel opened this issue Nov 22, 2022 · 4 comments
Assignees
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Milestone

Comments

@Wilson-Emmanuel
Copy link
Contributor

Wilson-Emmanuel commented Nov 22, 2022

Please could you take a look at this document.
ACLS Document

In the points that describe the four (4) tables used in the default implementation of the ACL Module, you did not provided any point for the ACL_OBJECT_IDENTITY table, even though it appear in the explanations. However, there seem to be a repeated explanation for the ACL_CLASS table.

@Wilson-Emmanuel Wilson-Emmanuel added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Nov 22, 2022
@sjohnr
Copy link
Member

sjohnr commented Nov 23, 2022

Thanks for reaching out, @Wilson-Emmanuel!

It looks as though an editing pass was made but the merge to the main branch had an errant conflict resolved that resulted in removing the ACL_OBJECT_IDENTITY point and duplicating the ACL_CLASS point. The duplicated (second) ACL_CLASS point looks as though it does not contain the edits.

I think the second ACL_CLASS point can be removed and the ACL_OBJECT_IDENTITY from 5.8.x could be restored in main (perhaps with an edit or two for consistency with the other points).

https://github.com/spring-projects/spring-security/blame/413c47311e88cb0038276038ff259f36e444538d/docs/modules/ROOT/pages/servlet/authorization/acls.adoc#L70-L72

Would you be interested in submitting a PR?

@sjohnr sjohnr self-assigned this Nov 23, 2022
@sjohnr sjohnr added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 23, 2022
@Wilson-Emmanuel
Copy link
Contributor Author

Thank you for the explanations. I have submitted a PR with the correction.

@Wilson-Emmanuel
Copy link
Contributor Author

Wilson-Emmanuel commented Dec 8, 2022

I have created a PR for this update but have not received any review.
@sjohnr Please could look into it?
Here is the PR : Wilson-Emmanuel:fixed-error-acls-doc

@sjohnr
Copy link
Member

sjohnr commented Dec 12, 2022

Hi @Wilson-Emmanuel. Apologies, I was traveling last week and have been quite busy the last few weeks. This is on my list today!

@sjohnr sjohnr added this to the 6.0.1 milestone Dec 15, 2022
@sjohnr sjohnr closed this as completed in edd1915 Dec 15, 2022
@sjohnr sjohnr assigned Wilson-Emmanuel and unassigned sjohnr Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants