Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fails due to HttpMethod changes #10569

Closed
sjohnr opened this issue Nov 30, 2021 · 0 comments
Closed

Test fails due to HttpMethod changes #10569

sjohnr opened this issue Nov 30, 2021 · 0 comments
Assignees
@sjohnr
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Milestone
6.0.0-M1

Comments

@sjohnr
Copy link
Member

sjohnr commented Nov 30, 2021

Describe the bug
Due to changes related to spring-projects/spring-framework#27697, the DefaultFilterInvocationSecurityMetadataSourceTests.unknownHttpMethodIsRejected test now fails. HttpMethod now supports custom methods, so UNKNOWN is no longer considered an invalid method.

To Reproduce
Run DefaultFilterInvocationSecurityMetadataSourceTests.unknownHttpMethodIsRejected.

Expected behavior
Tests should pass on main. To follow spring-framework, this test should be removed.
@sjohnr sjohnr added in: web An issue in web modules (web, webmvc) type: bug A general bug labels Nov 30, 2021
@sjohnr sjohnr added this to the 6.0.0-M1 milestone Nov 30, 2021
@sjohnr sjohnr self-assigned this Nov 30, 2021
@sjohnr sjohnr changed the title Test failing due to HttpMethod changes Test fails due to HttpMethod changes Nov 30, 2021
@sjohnr sjohnr closed this as completed in c6a27d4 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Milestone
6.0.0-M1
Development

No branches or pull requests
1 participant
@sjohnr