Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ConfigData processing code #23711

Closed
philwebb opened this issue Oct 15, 2020 · 0 comments
Closed

Improve ConfigData processing code #23711

philwebb opened this issue Oct 15, 2020 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

Out current ConfigData processing code is a little confusing due to the terms that we've used. Specifically we often refer to "config data location" in our docs, but in the code the ConfigDataLocation class refers to the resolved element.

I think it would be better if we consistently use location to mean the property that the user types. We can update the ConfigDataLocationResolver to return a ConfigDataResource (which aligns better with org.springframework.core.io.Resource).

There are few other areas of the code that can also be improved at the same time.

@philwebb philwebb self-assigned this Oct 15, 2020
@philwebb philwebb added the type: enhancement A general enhancement label Oct 15, 2020
@philwebb philwebb added this to the 2.4.x milestone Oct 15, 2020
@philwebb philwebb modified the milestones: 2.4.x, 2.4.0-M4 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant