You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
about this code snippet starting at AbstractKafkaStreamsBinderProcessor:627 (version 4.1.0):
if (timestampExtractor != null) {
consumed.withTimestampExtractor(timestampExtractor);
}
"consumed" is an Consumed-instance which is part of kafka-streams.
In kafka-streams 3.6.1 a call to consumed.withTimestampExtractor() changes the existing instance.
Since kafka-streams 3.7.0 the same call creates a new instance of "Consumed", but the code above ignores this new instance.
In the end, the timestampExtractor is not used at all since kafka 3.7.0.
Same for "consumed.withName" a couple of lines below.
IMHO this is a big change in kafka-streams inside a minor version change.
To fix this anyway the code above might be changed to
if (timestampExtractor != null) {
consumed = consumed.withTimestampExtractor(timestampExtractor);
}
Regards,
Ralf
The text was updated successfully, but these errors were encountered:
qxv1612
changed the title
Broken use of timestampExtractor in AbstractKafkaStreamsBinderProcessor with kafka-streams 3.7.0
AbstractKafkaStreamsBinderProcessor ignores TimestampExtractor starting with kafka-streams 3.7.0
Mar 19, 2024
qxv1612
changed the title
AbstractKafkaStreamsBinderProcessor ignores TimestampExtractor starting with kafka-streams 3.7.0
AbstractKafkaStreamsBinderProcessor ignores TimestampExtractor configuration starting with kafka-streams 3.7.0
Mar 19, 2024
Hello @sobychacko,
I forked the repo and created the PR based on the main branch. I'm not sure if this is the right method.
A local build currently fails in KafkaBinderTests, but I expect its related to my local env settings.
Actually I started the same test with the current main branch.
Hello,
about this code snippet starting at AbstractKafkaStreamsBinderProcessor:627 (version 4.1.0):
"consumed" is an Consumed-instance which is part of kafka-streams.
In kafka-streams 3.6.1 a call to consumed.withTimestampExtractor() changes the existing instance.
Since kafka-streams 3.7.0 the same call creates a new instance of "Consumed", but the code above ignores this new instance.
In the end, the timestampExtractor is not used at all since kafka 3.7.0.
Same for "consumed.withName" a couple of lines below.
IMHO this is a big change in kafka-streams inside a minor version change.
To fix this anyway the code above might be changed to
Regards,
Ralf
The text was updated successfully, but these errors were encountered: