Remove obsolate subsetting in Calc.load #284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another in the vein of #282, this one for data subsetting within Calc's loading functionality, none of which was documented and most of which was just placeholders for future implementations.
Note that I do use
Calc.load
itself, still, so that should remain for now. Although I think it would still make sense to segregate it fromCalc
itself eventually...maybe aCalcDataLoader
? @spencerkclark what do you think? We can open a separate issue to track that.