Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolate subsetting in Calc.load #284

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Conversation

spencerahill
Copy link
Owner

Another in the vein of #282, this one for data subsetting within Calc's loading functionality, none of which was documented and most of which was just placeholders for future implementations.

Note that I do use Calc.load itself, still, so that should remain for now. Although I think it would still make sense to segregate it from Calc itself eventually...maybe a CalcDataLoader? @spencerkclark what do you think? We can open a separate issue to track that.

Copy link
Collaborator

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I do use Calc.load itself, still, so that should remain for now. Although I think it would still make sense to segregate it from Calc itself eventually...maybe a CalcDataLoader?

Yes I think there is a lot of room for improvement here. When plotting data produced by aospy it is often helpful to not just load individual calculations, but to load groups of them. For example something as simple as loading a particular calculation for a set of runs, and concatenating along a new dimension indexed by the run names can be very convenient. I've written various functions over the years to do variants of that where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants