Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR https://github.com/speedb-io/speedb/pull/368 breaks public API compatibility #474

Closed
ofriedma opened this issue Apr 16, 2023 · 3 comments
Closed

PR https://github.com/speedb-io/speedb/pull/368 breaks public API compatibility #474

ofriedma opened this issue Apr 16, 2023 · 3 comments
Assignees
@ofriedma
Labels
bug Something isn't working

Comments

@ofriedma
Copy link
Contributor

ofriedma commented Apr 16, 2023 •
edited
Loading

PR #368 breaks public API compatibility, some applications using rocksdb do not compile because of the public api changes
@ofriedma ofriedma added the bug Something isn't working label Apr 16, 2023
@ofriedma ofriedma self-assigned this Apr 16, 2023
@Guyme
Copy link

Guyme commented Apr 20, 2023

currently paused until after the rebase

@Yuval-Ariel
Copy link
Contributor

@udi-speedb , are you aware? #368 has been removed from the current main

@udi-speedb udi-speedb mentioned this issue May 21, 2023
Closed
@Yuval-Ariel
Copy link
Contributor

updated implementation after 8.1 rebase does not change existing RocksDB public API -
#620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofriedma ofriedma

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ofriedma @Yuval-Ariel @Guyme