enable empty security definition #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
reviewed
Dec 10, 2019
This allows to use optional authentication and provide different responses to authenticated users via the same API-Endpoint. Co-Authored-By: Jacob Floyd <cognifloyd@gmail.com>
mblaettler
force-pushed
the
feat/enable-empty-security
branch
from
96cb9ad
to
b14e235
Compare
|
Thanks for fixing my typos. I squashed them into my commit. An empty security definition is not explicitly defined within the OpenAPI specification. But according to a comment in the OpenAPI-Secification Repo it should be possible. i also found support within the go server library as of this discussion. It would be great to see this feature within connexion, because there are a lot of use cases for optional auth. E.g. providing demo data for unauthenticated users or provide publicly available data (e.g. OpenData) without authorization and protected data via the same API endpoint. |
|
Hello, |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use optional authentication and provide different
responses to authenticated users via the same API-Endpoint.
Fixes #1036
Changes proposed in this pull request: