Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port #214 to v2 #215

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Port #214 to v2 #215

merged 1 commit into from
Apr 25, 2023

Conversation

weirdan
Copy link

@weirdan weirdan commented Apr 24, 2023 •
edited
Loading

No description provided.

@weirdan weirdan changed the base branch from main to v2 April 24, 2023 20:16
@freekmurze
Copy link
Member

I'm going to leave v2 as it is for now.

@freekmurze freekmurze closed this Apr 25, 2023
@weirdan
Copy link
Author

weirdan commented Apr 25, 2023

It would be easier for me to support v2 if it had minimal differences to main/v3.

@freekmurze freekmurze reopened this Apr 25, 2023
@freekmurze freekmurze merged commit ea4881f into spatie:v2 Apr 25, 2023
@freekmurze
Copy link
Member

Ok, let's do it as it's such a small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weirdan @freekmurze