Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 fix deprecated null parameters #187

Merged
merged 3 commits into from
May 8, 2022
Merged

Conversation

gigerIT
Copy link
Contributor

@gigerIT gigerIT commented May 7, 2022

fix #186 ($string) of type string is deprecated in PHP 8.1

Copy link
Contributor Author

@gigerIT gigerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix #186 DOMDocument::__construct(): Passing null to parameter #2 ($encoding) of type string is deprecated in vendor/spatie/array-to-xml/src/ArrayToXml.php on line 29

…ng) of type string is deprecated in vendor/spatie/array-to-xml/src/ArrayToXml.php on line 29
@gigerIT gigerIT changed the title fix #186 ($string) of type string is deprecated in PHP 8.1 PHP 8.1 fix deprecated null parameters May 7, 2022
@freekmurze freekmurze merged commit 14ac461 into spatie:main May 8, 2022
@freekmurze
Copy link
Member

Thanks!

@vasanthanand
Copy link

vasanthanand commented Nov 8, 2022

@freekmurze Is it possible to cherry pick and update this fix to 2.8.1 as well because of version conflics between php 7.4 and php 8.1.
In php 7.4 still the issue is there and because of other dependencies we are unable to update it to php 8.
Thank you so much in advance

@weirdan
Copy link

weirdan commented Dec 13, 2022

@vasanthanand the fix was backported to 2.x and is released in 2.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants