Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow null inside array to be converted to xml #170

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

tsuzukit
Copy link
Contributor

@tsuzukit tsuzukit commented Aug 18, 2021

Regarding this issue. https://github.com/spatie/array-to-xml/issues/169

This will allow null to be present in array.

For example, convert this array

$arr = [
    'test' => null,
];

ArrayToXml::convert($arr);

to below xml

<?xml version="1.0"?>
<root>
  <test/>
</root>

@tsuzukid
Copy link

tsuzukid commented Sep 5, 2021

Hi @freekmurze or someone in charge of merging PR

Sorry to rush, but it would be great if you can take a look at this PR.
If there is any concern, I am happy to fix!

Thanx!

@freekmurze freekmurze merged commit b80f142 into spatie:master Sep 5, 2021
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants