Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dropping XML declaration #145

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Add support for dropping XML declaration #145

merged 3 commits into from
Sep 14, 2020

Conversation

Dartui
Copy link
Contributor

@Dartui Dartui commented Sep 14, 2020

Fixes #144

Simple setter which allows dropping XML declaration. Useful for generating SOAP envelope.

Base snapshot driver must be used to see effects of this change.

freekmurze
freekmurze requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also document this feature in the readme?

src/ArrayToXml.php Outdated Show resolved Hide resolved
@Dartui
Copy link
Contributor Author

Dartui commented Sep 14, 2020

Done

@freekmurze freekmurze merged commit df172bd into spatie:master Sep 14, 2020
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze freekmurze requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to remove XML tag in output
2 participants
@Dartui @freekmurze