Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML::Builder not handling exceptions safely - 2372 #2373

Conversation

ric2b
Copy link
Contributor

@ric2b ric2b commented Nov 19, 2021

What problem is this PR intended to solve?

#2372

Have you included adequate test coverage?

I think so.

Does this change affect the behavior of either the C or the Java implementations?

Yes, since this changes non-platform specific code.

Co-authored-by: Joana Tavares jtavares@salsify.com

ric2b and others added 2 commits November 19, 2021 11:21
Co-authored-by: Joana Tavares <jtavares@salsify.com>
Co-authored-by: Joana Tavares <jtavares@salsify.com>
@ric2b ric2b changed the title Fix builder not handling exceptions safely - 2372 Fix XML::Builder not handling exceptions safely - 2372 Nov 19, 2021
@flavorjones flavorjones added the topic/builder XML::Builder behaviors label Nov 19, 2021
@flavorjones flavorjones added this to the v1.12.x patch releases milestone Nov 19, 2021
Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for taking the time to do this.

@flavorjones
Copy link
Member

I'll wait for CI to go green before merging.

@flavorjones
Copy link
Member

Please ignore the Windows Ruby 2.5 failures - they're unrelated and I'm investigating at #2354

@flavorjones
Copy link
Member

I've added a commit to this PR that updates the CHANGELOG with a thank-you to both @ric2b and @rinthedev

@ric2b
Copy link
Contributor Author

ric2b commented Nov 19, 2021

And thanks for looking at it so quickly! :)

@flavorjones flavorjones merged commit 820f99d into sparklemotion:main Nov 19, 2021
@flavorjones
Copy link
Member

Merged! Will ship in the next release (not sure yet whether that will be 1.12.6 or 1.13.0)

@ric2b ric2b deleted the 2372-fix-builder-not-handling-exceptions-safely branch November 22, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/builder XML::Builder behaviors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants